Skip to content

fix hash_with_views error#587

Merged
regisss merged 3 commits into
mainfrom
fix_hash
Dec 8, 2023
Merged

fix hash_with_views error#587
regisss merged 3 commits into
mainfrom
fix_hash

Conversation

@bgoldberg-habana
Copy link
Copy Markdown
Contributor

@bgoldberg-habana bgoldberg-habana commented Dec 7, 2023

fix hash_with_views error
this api is no longer valid at next release

@bgoldberg-habana
fix hash_with_views error
8171484 
Change-Id: I601e37de0b08f76e8a9ee74cdd3f5d9e2cefef05
@bgoldberg-habana
make style
06397cf 
Change-Id: I5d1fd49bce5f9d20d3e7bf8af2595d6dfb15168b
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Dec 7, 2023

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Dec 7, 2023

"next release" means SynapseAI v1.14?

@bgoldberg-habana
Copy link
Copy Markdown
Contributor Author

bgoldberg-habana commented Dec 7, 2023

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Dec 7, 2023

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

Okay, so we should wait for 1.14 to be released before merging this PR right?

@bgoldberg-habana
Copy link
Copy Markdown
Contributor Author

bgoldberg-habana commented Dec 7, 2023

"next release" means SynapseAI v1.14?

yes, we remove this parameter from api.

Okay, so we should wait for 1.14 to be released before merging this PR right?

no, we need it now for internal use..

regisss
regisss reviewed Dec 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see. Let's just add a comment to remove this check at some point (when 1.15 is released I think).

Comment thread examples/text-generation/utils.py
@bgoldberg-habana @regisss
Update examples/text-generation/utils.py
32a712e 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
regisss
regisss approved these changes Dec 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit f6af3fe into main Dec 8, 2023
@regisss regisss deleted the fix_hash branch December 8, 2023 09:08
schoi-habana added a commit that referenced this pull request Dec 20, 2023
@schoi-habana
Fix for Falcon error from PR #587
230e9ad
@schoi-habana schoi-habana mentioned this pull request Dec 20, 2023
Merged
3 tasks
libinta pushed a commit that referenced this pull request Dec 21, 2023
@schoi-habana
Fix for Falcon error from PR #587 (#608)
cba7f00 
* Fix for Falcon error from PR #587

* Reformatted
dsocek pushed a commit to dsocek/optimum-habana that referenced this pull request Jan 4, 2024
@schoi-habana @dsocek
Fix for Falcon error from PR huggingface#587 (huggingface#608)
434d9ac 
* Fix for Falcon error from PR huggingface#587

* Reformatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regisss regisss regisss approved these changes

@libinta libinta libinta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bgoldberg-habana @HuggingFaceDocBuilderDev @regisss @libinta